Fixes rosetta tests from overwriting artifacts from upstream tests #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashors1
approved these changes
Oct 4, 2023
|
Actually upon further investigation, this doesn't seem to be a problem currently because ci.yaml only runs test{pax,t5x}.yaml once, (ex: https://github.com/NVIDIA/JAX-Toolbox/blob/main/.github/workflows/ci.yaml#L228). For the public facing workflows, we haven't run into this b/c they all get their own GITHUB_RUN_ID when triggered via upstream public facing workflows Moving this to draft since ci.yaml needs to be updated too |
|
Is this issue addressed by #298? Can we close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Artifacts have been uploaded to
${GITHUB_RUN_ID}-${TEST_CASE_NAME}, but now that the_test_{t5x,pax}.yamlare potentially called twice in a single run (e.g., in ci.yaml), we can have artifacts that clobber each other. This change adds aSUFFIXinput that will prevent them from clobbering each other