Check for fmuexport binary #188
Conversation
|
hello @markaren, what do you think about this one ? |
|
Sorry for not reacting to this PR. It is likely OK. I might find a need to use this library again in the near future and will look into adding this then. |
|
ping @markaren |
|
thanks! |
|
I think this is not a good idea, this code breaks the functionality when you run the Python code from inside the FMU as the binaries are not placed at "/resources/binaries/{win64 or linux64}/pythonfmu.so". Instead the binaries inside the FMU are just placed at /binaries. This 'has_binary' function was made to be used by the builder to check if the pythonfmu installation had the correct binaries, running this code from the FMU won't work as expected and causes the FMU to fail when instantiating |
I also stumbled on #129, one possibility to address this is to raise at the import
Maybe we could also just send a warning message, maybe if there are legitimate uses of fmuexport that dont require the binary but I dont know
Closes #129