Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pvlib clearsky filter test in analysis chain #441

Merged
merged 12 commits into from
Dec 30, 2024
Merged

Conversation

martin-springer
Copy link
Collaborator

@martin-springer martin-springer commented Dec 4, 2024

  • Code changes are covered by tests
  • Code changes have been evaluated for compatibility/integration with TrendAnalysis
  • New functions added to __init__.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • Updated changelog

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.91%. Comparing base (eb05586) to head (a4a5330).

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #441      +/-   ##
===============================================
- Coverage        96.17%   95.91%   -0.27%     
===============================================
  Files               11       11              
  Lines             2251     2251              
===============================================
- Hits              2165     2159       -6     
- Misses              86       92       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdeceglie mdeceglie merged commit c59708a into development Dec 30, 2024
19 checks passed
@mdeceglie mdeceglie deleted the fix_issue_#376 branch December 30, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants