Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advance pvlib upper bound from 0.11 to 0.12 #423

Merged
merged 5 commits into from
Jul 3, 2024

Conversation

kandersolar
Copy link
Member

  • Code changes are covered by tests
  • Code changes have been evaluated for compatibility/integration with TrendAnalysis
  • New functions added to __init__.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • Updated changelog

RdTools currently requires pvlib<0.11.0. With pvlib now in the 0.11.x series, I don't think there turned out to be any relevant breaking changes (see what's new), so we can increase that upper limit to allow 0.11.*.

@mdeceglie
Copy link
Collaborator

Thanks for the PR @kandersolar! For ease of managing the flow here, I'm going to sweep this into our changes for 3.0 expected this summer.

@mdeceglie mdeceglie changed the base branch from master to aggregated_filters_for_trials July 3, 2024 19:15
@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.10%. Comparing base (ab8bdc8) to head (449cca9).

Additional details and impacted files
@@                      Coverage Diff                       @@
##           aggregated_filters_for_trials     #423   +/-   ##
==============================================================
  Coverage                          96.10%   96.10%           
==============================================================
  Files                                 11       11           
  Lines                               2206     2206           
==============================================================
  Hits                                2120     2120           
  Misses                                86       86           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdeceglie
Copy link
Collaborator

It's not immediately clear which of the breaking changes listed in the pvlib docs are causing the tests to fail. any thoughts @kandersolar?

@kandersolar
Copy link
Member Author

@mdeceglie it looks to be fixed now!

@mdeceglie mdeceglie merged commit f1726ab into aggregated_filters_for_trials Jul 3, 2024
16 checks passed
@mdeceglie mdeceglie deleted the pvlib-0.11.0 branch July 3, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants