adding code climate badge #344
Conversation
|
@GUI - okay to merge this? |
|
Oops, sorry for the delay. I had started to look into this when you submitted the PR, but then got sidetracked. The current Code Climate SVG link in this PR goes to a "not found" page, and Code Climate seems to have errored out on the repo 5 months ago and hasn't been updated since (https://codeclimate.com/github/NREL/api-umbrella/builds/1). I know years ago we had Code Climate setup, so there might be old vestiges of that setup that don't seem to be properly working any longer. I'll try poking around to see what I can find. |
|
@gbinal: Okay, I had to tweak the webhook settings, but Code Climate is now running against this repo: https://codeclimate.com/github/NREL/api-umbrella Although, I think the SVG URL needs to be But more generally speaking, it looks like this request is related to compliance/ATO stuff, is that correct? I'm just wondering what's important from your perspective out of Code Climate. By default, it's reporting tons of issues (700+), so it will take some time to sift through all that and figure out what's relevant. But on a quick glance, all of the issues are qualified as "minor" and a lot of them seem more style-related (for example, it thinks these lines are too similar) or are in 3rd party vendor code. We can customize Code Climate's configuration, or we can address some of these style issues, but before doing any of that, I was just wondering if there were any specific things that were important to you in Code Climate (ie, do you care about style issues or not). |
|
Great - thanks for catching that. I've updated the PR if you're game to merge. |
No description provided.