Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CompiledModel class which can generate DataFrames and Tables #359

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

gtfierro
Copy link
Collaborator

@gtfierro gtfierro commented Nov 7, 2024

This changes Model.compile so it returns a new CompiledModel class. This is not stored in the database; it is an ephemeral class which stores the compiled model and provides some convenience methods. In particular, it can generate DataFrames or SQL tables from SHACL shapes.

See example here

@TShapinsky @MatthewSteen what do you think of the abstraction? Once we figure out what this should look like then I can propagate the changes to the rest of the codebase and add tests

@gtfierro
Copy link
Collaborator Author

From dev discussion:

  • can we avoid duplicated code? Factor them out into their own "superclass"
  • move this to its own file?
  • keep it out of the database (stay in-memory)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant