Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n support #26

Open
Pevernow opened this issue Jul 20, 2020 · 4 comments
Open

i18n support #26

Pevernow opened this issue Jul 20, 2020 · 4 comments

Comments

@Pevernow
Copy link

As mentioned in the topic.

@taikedz
Copy link
Contributor

taikedz commented Jul 21, 2020

NSSM has no i18n support - as witnessed in the code.

Are you interested in adding it? Or requesting it? Or something else?

At any rate, NPXcoot has not been seen in years, so this mod is pretty much at a standstill.

I breifly tried to maintain NSSM and do bugfixes a couple years ago but have not been active myself lately, though I do still do bugfixes and take pull requests: https://github.com/minetest-mobs-mods/nssm/

Adding i18n is a rather big undertaking so unless someone wants to put in the time and effort on this, it's not coming soon....

@Pevernow
Copy link
Author

I think I can try to adding it.
But NPXcoot has not been seen in years.
He can see I submitted "pull request" when I pull it?

@Pevernow
Copy link
Author

If someone can go through my pull request, I'll do it

@taikedz
Copy link
Contributor

taikedz commented Jul 22, 2020

Team NPX is no longer is in the community. They left without saying anything :-(

If you fork and make the changes, and submit the Pull Request to NPXCoot/nssm, it will remain unseen and unmerged forever.

You can PR the changes to this one instead if you want: https://github.com/minetest-mobs-mods/nssm/

However as of testing in the context of #25 I've seen that NSSM might not be properly compatible with Minetest 5.x and so we might have to consider NSSM as "legacy/obsolete": NPX is not maintaining their copy, and I have not had the time to work on Minetest for a while. Minetest and mobs_redo have evolved significantly since NSSM's last formal commit/release, and a lot of work would need to be done, including in graphics areas where I have zero experience, to bring it back up to compatibility.

It would probably be best to find a team on the forums to create a new monster mods pack to put together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants