Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What's the deal with Player.getPlayerId? #215

Open
SoniEx2 opened this issue Aug 20, 2016 · 0 comments
Open

What's the deal with Player.getPlayerId? #215

SoniEx2 opened this issue Aug 20, 2016 · 0 comments
Labels
question Issues where a question or problem is stated and a discussion is held to gather information.

Comments

@SoniEx2
Copy link
Contributor

SoniEx2 commented Aug 20, 2016 •
edited
Loading

So, it seems that Player.getPlayerId is game-specific, while Player.getId is global... At least, that's how the wrappers implement it.

Shouldn't it be the other way around? The name "getPlayerId" seems to imply it's something that is permanent - that never changes; but according to the code, it is not. They could also be made to return the same value - the UUID.

cc @calclavia
@RX14 RX14 added the question Issues where a question or problem is stated and a discussion is held to gather information. label Aug 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Issues where a question or problem is stated and a discussion is held to gather information.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SoniEx2 @RX14