Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __bool__ to ParquetStore #232

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Conversation

jarq6c
Copy link
Collaborator

@jarq6c jarq6c commented Aug 24, 2023

Closes #231

Additions

  • New __bool__ dunder method that tests the string representation of ParquetStore.

Removals

Changes

Testing

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • PR is well outlined and documented. See #12 for an example
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (see CONTRIBUTING.md)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output) using numpy docstring formatting
  • Placeholder code is flagged / future todos are captured in comments
  • Reviewers requested with the Reviewers tool ➡️

@jarq6c jarq6c added the bug Something isn't working label Aug 24, 2023
@jarq6c jarq6c self-assigned this Aug 24, 2023
@jarq6c jarq6c merged commit 64ba85d into NOAA-OWP:main Aug 24, 2023
@jarq6c jarq6c deleted the add-bool-pq-store branch August 24, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nwm_client_new get methods fails with custom Parquet Store
1 participant