Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Things to do for final unified_ugwp_v1 code #58

Open
mdtoy opened this issue Oct 22, 2020 · 0 comments
Open

Things to do for final unified_ugwp_v1 code #58

mdtoy opened this issue Oct 22, 2020 · 0 comments

Comments

@mdtoy
Copy link

mdtoy commented Oct 22, 2020

The unified_ugwp drag scheme incorporates the cires_ugwp_v0 code (used in FV3GFSv16) and the GSL (RAP/HRRR) orographic drag suite. These two schemes are fully functional, however, the ugwp_v1 code by Valery Yudin, also included, but it needs a little more work. Below is a reminder of some of the issues that need to be addressed:

  1. physics/cires_ugwp_module_v1.F90: Need to make sure when the call to calendar_ugwp occurs in your current code. In the init phase? If so, we may have to add the julian day calculation to the init phase of GFS_phys_time_vary_init subroutine.

There are also unresolved conversations in the PR (#55) which need to be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant