-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark with DaCe cpu and gpu backends #50
Changes from 8 commits
f1d77b8
038caf4
3bd1772
3ea7ce3
5d3539f
e7f2c39
6f4d710
e69aaa1
735e972
095ec26
0c68c5f
29a4727
101980d
d0696f3
34eeea4
208fd62
e7fd3b4
ea4762f
35ef834
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
[submodule "external/gt4py"] | ||
path = external/gt4py | ||
url = https://github.com/gridtools/gt4py.git | ||
[submodule "external/dace"] | ||
[submodule "dacecpufix"] | ||
path = external/dace | ||
url = https://github.com/spcl/dace.git | ||
url = https://github.com/FlorianDeconinck/dace.git | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,11 +15,10 @@ performance_config: | |
nx_tile: 384 | ||
nz: 79 | ||
dt_atmos: 450 | ||
minutes: 7 | ||
seconds: 30 | ||
days: 9 | ||
layout: | ||
- 1 | ||
- 1 | ||
- 16 | ||
- 16 | ||
diagnostics_config: | ||
path: output | ||
output_format: netcdf | ||
|
@@ -72,7 +71,7 @@ dycore_config: | |
nwat: 6 | ||
p_fac: 0.1 | ||
rf_cutoff: 800. | ||
rf_fast: false | ||
rf_fast: true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Has rf_fast=True been implemented? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It has not, but when run with it set to false, it throws an NotImplementedError when tau != 0. Should this instead be removed or tau == 0? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You could cherry pick over the not-implemented PR from Florian and remove the options from the yaml config. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think I'd rather change tau than set something in the config that we haven't actually implemented in the model, at least for now. I'll create an issue for it as well though so we can implement a config that's internally consistent. |
||
tau: 5. | ||
vtdm4: 0.06 | ||
z_tracer: true | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really do not love doing this, cannot wait to have it resolved