Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intakebuilder --> catalogbuilder #128

Closed
ilaflott opened this issue Jul 24, 2024 · 0 comments · Fixed by #140
Closed

intakebuilder --> catalogbuilder #128

ilaflott opened this issue Jul 24, 2024 · 0 comments · Fixed by #140
Labels
good first issue Good for newcomers

Comments

@ilaflott
Copy link
Member

Describe the bug
This bug is about-to-be-existing, as noaa-gfdl::intakebuilder still exists, but is being replaced with noaa-gfdl::catalogbuilder. the code will begin to complain the module intakebuilder does not exist. lines like import intakebuilder must be changed to something like import catalogbuilder.intakebuilder to remain consistent and have equivalent functioning.

To Reproduce
When noaa-gfdl::intakebuilder is deleted, one will have to do nothing to see the problem. it will show up in pipelines with fre catalog calls. Locally, one would need to conda env create with an up-to-date environment.yaml omitting intakebuilder deliberately and locally pip installing the right branch of CatalogBuilder to see the exact bug.

Expected behavior
no error messages described as above.

Additional context
CatalogBuilder development

@ilaflott ilaflott added the good first issue Good for newcomers label Jul 24, 2024
@ilaflott ilaflott linked a pull request Aug 1, 2024 that will close this issue
6 tasks
@ilaflott ilaflott closed this as completed Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant