From 8f1a96e2cea5f9895848986c3727b9ee855d8528 Mon Sep 17 00:00:00 2001 From: "Kelli.Johnson" <1536491690113302@mil> Date: Tue, 2 Jul 2024 14:42:38 -0700 Subject: [PATCH] refactor: Deletes issue and PR templates They have been moved and updated in NOAA-FIMS/.github/.github with NOAA-FIMS/.github@33c261d. Now they are available to all repositories not just NOAA-FIMS/FIMS. I did not migrate over the refactor_request issue template because it was largely redundant with the developer_other_issue template and I thought it was not needed. --- .github/ISSUE_TEMPLATE/bug_report.yml | 79 ------------------- .../ISSUE_TEMPLATE/developer_other_issue.yml | 19 ----- .github/ISSUE_TEMPLATE/feature_request.yml | 56 ------------- .github/ISSUE_TEMPLATE/refactor_request.yml | 18 ----- .github/pull_request_template.md | 64 --------------- 5 files changed, 236 deletions(-) delete mode 100644 .github/ISSUE_TEMPLATE/bug_report.yml delete mode 100644 .github/ISSUE_TEMPLATE/developer_other_issue.yml delete mode 100644 .github/ISSUE_TEMPLATE/feature_request.yml delete mode 100644 .github/ISSUE_TEMPLATE/refactor_request.yml delete mode 100644 .github/pull_request_template.md diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml deleted file mode 100644 index e21772f42..000000000 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ /dev/null @@ -1,79 +0,0 @@ -name: Bug Report -description: Report a bug that causes the existing functionality to differ from what is described in the development plan -title: "[Bug]: " -labels: ["kind: bug", "status: triage_needed"] -body: - - type: markdown - attributes: - value: | - Thanks for taking the time to fill out this bug report! By - submitting this issue, you agree to follow our - [Code of Conduct](https://noaa-fims.github.io/collaborative_workflow/code-of-conduct.html#code-of-conduct). - - type: textarea - id: describe - attributes: - label: Describe the bug - description: A clear and concise description of what the bug is. - validations: - required: true - - type: textarea - id: reproduce - attributes: - label: To Reproduce - description: | - Please include a minimal reproducible example (AKA a reprex). If you - have not heard of a [reprex](http://reprex.tidyverse.org/) before, - you can start by reading about them on the [tidyverse - blog](https://www.tidyverse.org/help/#reprex). Feel free to copy, paste, - and edit the [demo - vignette](https://github.com/NOAA-FIMS/FIMS/blob/4539fc4b6e65b901231c4fb66a113bb5b5d54d22/vignettes/fims-demo.Rmd) - for your reprex. - placeholder: | - # insert reprex here - validations: - required: false - - type: textarea - id: screenshots - attributes: - label: Screenshots - description: If applicable, add screenshots to help explain your problem. - validations: - required: false - - type: dropdown - id: os - attributes: - label: Which OS are you seeing the problem on? - multiple: true - options: - - Windows - - Mac - - Linux - - Other - validations: - required: false - - type: dropdown - id: browser - attributes: - label: Which browser are you seeing the problem on? - multiple: true - options: - - Firefox - - Chrome - - Safari - - Microsoft Edge - - Other - validations: - required: false - - type: input - id: version - attributes: - label: Which version of FIMS are you seeing the problem on? - validations: - required: false - - type: textarea - id: context - attributes: - label: Additional Context - description: Add any other context about the problem here. - validations: - required: false diff --git a/.github/ISSUE_TEMPLATE/developer_other_issue.yml b/.github/ISSUE_TEMPLATE/developer_other_issue.yml deleted file mode 100644 index 29e927451..000000000 --- a/.github/ISSUE_TEMPLATE/developer_other_issue.yml +++ /dev/null @@ -1,19 +0,0 @@ -name: Developer (other issue) -description: For FIMS implementation team members to document other types of issues -title: "[Developer Issue]: " -labels: ["status: triage_needed"] -body: - - type: markdown - attributes: - value: | - Thanks for taking the time to fill out this issue! By - submitting this issue, you agree to follow our - [Code of Conduct](https://noaa-fims.github.io/collaborative_workflow/code-of-conduct.html#code-of-conduct). - - type: textarea - id: describe - attributes: - label: Issue details - description: Describe the issue - validations: - required: true - \ No newline at end of file diff --git a/.github/ISSUE_TEMPLATE/feature_request.yml b/.github/ISSUE_TEMPLATE/feature_request.yml deleted file mode 100644 index 259c5181c..000000000 --- a/.github/ISSUE_TEMPLATE/feature_request.yml +++ /dev/null @@ -1,56 +0,0 @@ -name: Feature Request -description: Request new features or changes to features, such that the described functionality differs from what is currently in the development plan -title: "[Feature]: " -labels: ["kind: enhancement", "status: triage_needed"] -body: - - type: markdown - attributes: - value: | - Thanks for taking the time to fill out this feature request! By - submitting this issue, you agree to follow our - [Code of Conduct](https://noaa-fims.github.io/collaborative_workflow/code-of-conduct.html#code-of-conduct). - - type: textarea - id: problem - attributes: - label: Is your feature request related to a problem? Please describe. - description: A clear and concise description of what the problem is. - placeholder: I'm always frustrated when... - validations: - required: true - - type: textarea - id: solution - attributes: - label: Describe the solution you would like. - description: A clear and concise description of what you want to happen. - validations: - required: true - - type: textarea - id: alternatives - attributes: - label: Describe alternatives you have considered - description: A clear and concise description of any alternative solutions or features you have considered. - placeholder: Other solutions include ... - validations: - required: true - - type: textarea - id: stats - attributes: - label: Statistical validity, if applicable - description: Please link to a paper or reference that describes how this approach improves accuracy or statistical power. - validations: - required: false - - type: textarea - id: management - attributes: - label: Describe if this is needed for a management application - description: If this feature is necessary to satisfy the Terms of Reference for your fishery management body, please explain why here and describe which management body. - validations: - required: false - - type: textarea - id: context - attributes: - label: Additional context - description: Add any other context or screenshots about the feature request here. - validations: - required: false - \ No newline at end of file diff --git a/.github/ISSUE_TEMPLATE/refactor_request.yml b/.github/ISSUE_TEMPLATE/refactor_request.yml deleted file mode 100644 index 115f6c71d..000000000 --- a/.github/ISSUE_TEMPLATE/refactor_request.yml +++ /dev/null @@ -1,18 +0,0 @@ -name: Refactor -description: Change the current structure of the code -title: "[Refactor]: " -labels: ["kind: refactor", "status: triage_needed"] -body: - - type: markdown - attributes: - value: | - Thanks for taking the time to fill out this refactor request! By - submitting this issue, you agree to follow our - [Code of Conduct](https://noaa-fims.github.io/collaborative_workflow/code-of-conduct.html#code-of-conduct). - - type: textarea - id: describe - attributes: - label: Refactor request - description: Describe what needs to be refactored and why - validations: - required: true diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md deleted file mode 100644 index 0fc4ecdd4..000000000 --- a/.github/pull_request_template.md +++ /dev/null @@ -1,64 +0,0 @@ - - -# What is the feature? - - -* - -# How have you implemented the solution? - - - -# Does the PR impact any other area of the project? - - - -# How to test this change - - -# Developer pre-PR checklist - -- [x] I relied on GitHub actions to :test_tube: things for me while I sat on the :couch_and_lamp:. - - - -