Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create "extra" subdirectory at the top level, and move user-contributed code that we will not support into it #206

Open
edwardhartnett opened this issue Jul 22, 2024 · 3 comments · May be fixed by #279
Open

create "extra" subdirectory at the top level, and move user-contributed code that we will not support into it #206

edwardhartnett opened this issue Jul 22, 2024 · 3 comments · May be fixed by #279
Assignees
@webisu @AlysonStahl-NOAA
Labels
build Relates to the build system

Comments

@edwardhartnett
Copy link
Contributor

We have features like the mysql compatibility, which were contributed by users but are of no interest to NOAA.

We will not write testing or documentation for these codes.

Instead, let's move them to an "extra" directory at the top level. They extra directory can be optionally built. When built, it's CMakeLists.txt builds the code in the extra directory into a library that the rest of wgrib2 links to.

@webisu , other than the mysql code, what other features are extra?
@edwardhartnett edwardhartnett added the build Relates to the build system label Jul 22, 2024
@AlysonStahl-NOAA
Copy link
Collaborator

I'm not sure why, but I just caught that there are two projects titled wgrib2-3.5.0. The duplicate one contained this issue and one other closed issue.

I just moved this and the other issue to the correct project.

@edwardhartnett
Copy link
Contributor Author

Probably my fault. Delete the unwanted project...

@AlysonStahl-NOAA AlysonStahl-NOAA linked a pull request Oct 16, 2024 that will close this issue
Draft
@AlysonStahl-NOAA
Copy link
Collaborator

I've started this issue a little while ago and was having some problems with it. I think I may need to go over it in our next meeting. I'm going to move this to the next project so we can move forward with the 3.5.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@webisu webisu

@AlysonStahl-NOAA AlysonStahl-NOAA

Labels
build Relates to the build system
Projects
wgrib2-3.6.0
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Moving all user-contributed code to new top-level subdirectory AlysonStahl-NOAA/wgrib2
3 participants
@webisu @edwardhartnett @AlysonStahl-NOAA