Remove the submodules #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danholdaway looks like we need some |
CoryMartin-NOAA
approved these changes
Jun 4, 2024
|
Where and how do the changes in this PR tie into GDASApp and g-w? |
|
@RussTreadon-NOAA I will work on the GDASapp and GW workflows next. |
|
GDASApp PR #11146 has been merged. Do likewise for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be problematic to have JCB use submodules explicitly and since they are really only used for testing they are removed. In their place is a custom checkout script that performs the exact same work as the git submodules but has to be run manually, as reflected in the README.
Users adding testing of a client simply register it in a YAML file, similar to how a
.gitmodulesfile would look.Depends: