Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/vegtype export #888

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

bbakernoaa
Copy link

@bbakernoaa bbakernoaa commented Nov 22, 2024

Description

This pull request includes updates to the update_atmos_chemistry subroutine in atmos_model.F90 and modifications in the module_cplfields module in cpl/module_cplfields.F90. The changes primarily focus on incorporating the vtype (vegetation type) variable into the atmospheric chemistry update process.

Updates to atmos_model.F90:

  • Added vtype to the list of variables in update_atmos_chemistry subroutine.
  • Included a call to cplFieldGet to retrieve the vegetation_type field and assign it to vtype.
  • Updated the reshaping and type conversion logic to include vtype.
  • Added logging for vtype to output its min, max, and average values.

Modifications to cpl/module_cplfields.F90:

  • Commented out the fraction_of_vegetation_category and number_of_vegetation_categories fields in the FieldInfo list.
  • Added vegetation_type to the list of fields, and commented out number_of_vegetation_categories and fraction_of_vegetation_category.

closes #889
This PR goes along with AQM#103

Issue(s) addressed

Testing

Dependencies

Should be paired with bbakernoaa/aqm/feature/vegtype

Requirements before merging

  • All new code in this PR is tested by at least one unit test
  • All new code in this PR includes Doxygen documentation
  • All new code in this PR does not add new compilation warnings (check CI output)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add vegetation_type to chemistry exports SLTYP incorrectly assigned to land use or vtype
1 participant