Update JEDI hashes to include Model Variable Renaming Sprint #1355

RussTreadon-NOAA · 2024-10-30T15:43:42Z

This PR updates JEDI hashes in sorc/ to bring in changes associated with the Model Variable Renaming Sprint. This is required to fully resolve #1313.

Resolves #1313
Resolves #1362

Depends: jcb-gdas #45

emcbot · 2024-10-30T16:11:51Z

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Wed Oct 30 16:11:17 UTC 2024 on hfe10
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Oct 30 16:11:48 UTC 2024
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Wed Oct 30 16:11:51 UTC 2024
Tests:

emcbot · 2024-10-30T19:08:03Z

Automated GDASApp Testing Results:
Machine: hera

Start: Wed Oct 30 18:10:20 UTC 2024 on hfe04
---------------------------------------------------
Build:                                  *FAILED*
Build: Failed at Wed Oct 30 19:08:03 UTC 2024
Build: see output at /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/PR/1355/GDASApp/log.build

emcbot · 2024-10-30T20:35:15Z

Automated GDASApp Testing Results:
Machine: hera

Start: Wed Oct 30 19:40:23 UTC 2024 on hfe04
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Oct 30 20:32:02 UTC 2024
---------------------------------------------------

emcbot · 2024-10-31T11:14:12Z

Automated GDASApp Testing Results:
Machine: hera

Start: Thu Oct 31 10:24:14 UTC 2024 on hfe03
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Oct 31 11:12:02 UTC 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Thu Oct 31 11:14:12 UTC 2024
Tests: 76% tests passed, 8 tests failed out of 33
	1953 - test_gdasapp_bufr2ioda_insitu_profile_argo (Failed)
	1954 - test_gdasapp_bufr2ioda_insitu_profile_bathy (Failed)
	1955 - test_gdasapp_bufr2ioda_insitu_profile_glider (Failed)
	1956 - test_gdasapp_bufr2ioda_insitu_profile_tesac (Failed)
	1957 - test_gdasapp_bufr2ioda_insitu_profile_tropical (Failed)
	1958 - test_gdasapp_bufr2ioda_insitu_profile_xbtctd (Failed)
	1959 - test_gdasapp_bufr2ioda_insitu_surface_drifter (Failed)
	1960 - test_gdasapp_bufr2ioda_insitu_surface_trkob (Failed)
Tests: see output at /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/PR/1355/GDASApp/build/log.ctest

RussTreadon-NOAA · 2024-11-05T19:57:26Z

Will keep this PR in draft mode until GDASApp and jcb-gdas yamls and templates work with updated JEDI hashes.

…1362)

)

… Sprint (#1362)

…#1362)

…ions sections to insitu_profile yamls (#1362)

…on of several insitue obs) (#1362)

RussTreadon-NOAA · 2024-11-15T19:38:48Z

The changes in this PR have been tested in g-w PR #2992.

Tests completed include:

test_gdasapp
- 64/64 tests pass on Hera, Hercules, and Orion
g-w DA CI
- four configurations tested: GSI, JEDI ATM, JEDI Aerosol/Snow, JEDI WCDA
- all four configurations successfully run all jobs on Hera, Hercules, and Orion
- GSI and JED ATM CI work _as is" on Dogwood (WCOSS2)
- JEDI Aerosol/Snow DA and JEDI WCDA work on Dogwood when GDASApp branch feature/resume_nightly' (this PR) is built with spack-stack/1.6.0`

RussTreadon-NOAA · 2024-11-15T19:40:59Z

This PR SHOULD NOT be merged into develop until jcb-gdas PR #45 is approved and merged into jcb-gdas develop. Once this is done, the parm/jcb-gdas hash in feature/resume_nightly should be updated to the new jcb-gdas develop hash.

RussTreadon-NOAA · 2024-11-15T19:50:46Z

@guillaumevernieres , @AndrewEichmann-NOAA , @DavidNew-NOAA, @CoryMartin-NOAA - this PR is ready for final review. It's been tested in g-w #2992.

DavidNew-NOAA

Looks good, especially given all the testing. Nice work, @RussTreadon-NOAA

RussTreadon-NOAA · 2024-11-15T19:55:43Z

Thank you @DavidNew-NOAA and @CoryMartin-NOAA for the quick approvals. I'll go ahead and merge.

add set -x to ci/driver.sh (#1313)

4dffe3a

RussTreadon-NOAA self-assigned this Oct 30, 2024

RussTreadon-NOAA added the hera-GW-RT Queue for automated testing with global-workflow on Hera label Oct 30, 2024

emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Oct 30, 2024

emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Oct 30, 2024

RussTreadon-NOAA added hera-RT Queue for automated testing on Hera and removed hera-GW-RT-Passed Automated testing with global-workflow successful on Hera labels Oct 30, 2024

RussTreadon-NOAA assigned DavidNew-NOAA Oct 30, 2024

emcbot added the hera-RT-Passed Automated testing successful on Hera label Oct 30, 2024

RussTreadon-NOAA added hera-RT Queue for automated testing on Hera and removed hera-RT Queue for automated testing on Hera hera-RT-Passed Automated testing successful on Hera labels Oct 30, 2024

emcbot added hera-RT-Running Automated testing running on Hera and removed hera-RT Queue for automated testing on Hera labels Oct 30, 2024

RussTreadon-NOAA added hera-RT Queue for automated testing on Hera and removed hera-RT-Running Automated testing running on Hera labels Oct 30, 2024

emcbot added hera-RT-Running Automated testing running on Hera and removed hera-RT Queue for automated testing on Hera labels Oct 30, 2024

emcbot added hera-RT-Failed Automated testing failed on Hera and removed hera-RT-Running Automated testing running on Hera labels Oct 30, 2024

RussTreadon-NOAA added hera-RT Queue for automated testing on Hera and removed hera-RT-Failed Automated testing failed on Hera labels Oct 31, 2024

emcbot added hera-RT-Running Automated testing running on Hera and removed hera-RT Queue for automated testing on Hera labels Oct 31, 2024

RussTreadon-NOAA and others added 14 commits November 11, 2024 10:11

Merge branch 'develop' into feature/resume_nightly

aef7bcc

update jedi hashes in sorc/ using ush/submodules/update_develop.sh (#…

bbb07ab

…1362)

update yamls to be consistent with model variable renaming sprint (#1362

dc4359b

)

update jcb-gdas hash to bring in changes from Model Variable Renaming…

4561ead

… Sprint (#1362)

Merge branch 'develop' into feature/resume_nightly

68bc5e2

update variable names in marine yamls, jcb-gdas, and gdas_soca_diag.h (…

beeee4c

…#1362)

shorten lines to conform with c++ coding norms (#1362)

937c3be

replace tabs with whitespace to confirm with c++ coding norms (#1362)

d908c1f

Merge branch 'develop' into feature/resume_nightly

1747c0a

Merge branch 'develop' into feature/resume_nightly

bab9f8b

update fv3-jedi hash (#1362)

5b8e1dd

update state variable names for soca letkf, add missing obs localizat…

05d592d

…ions sections to insitu_profile yamls (#1362)

revert soca/obs/obs_list.yaml to previous version (turn off assimlati…

716dcdb

…on of several insitue obs) (#1362)

update jcb-gdas hash (#1362)

13a5dc6

RussTreadon-NOAA marked this pull request as ready for review November 15, 2024 19:33

This was referenced Nov 15, 2024

Update variables to be consistent with updated jedi hashes NOAA-EMC/jcb-gdas#45

Merged

JCB-based obs+bias staging, Jedi class updates, and marine B-matrix refactoring NOAA-EMC/global-workflow#2992

Merged

update parm/jcb-gdas to point at develop (#1362)

4354873

DavidNew-NOAA approved these changes Nov 15, 2024

View reviewed changes

CoryMartin-NOAA approved these changes Nov 15, 2024

View reviewed changes

RussTreadon-NOAA merged commit e514b92 into develop Nov 15, 2024
5 checks passed

RussTreadon-NOAA deleted the feature/resume_nightly branch November 15, 2024 19:56

WalterKolczynski-NOAA added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Failed Automated testing with global-workflow failed on Hera labels Nov 15, 2024

RussTreadon-NOAA mentioned this pull request Nov 19, 2024

Update jedi hashes in response to model variable naming sprint #1317

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update JEDI hashes to include Model Variable Renaming Sprint #1355

Update JEDI hashes to include Model Variable Renaming Sprint #1355

RussTreadon-NOAA commented Oct 30, 2024 •

edited

Loading

emcbot commented Oct 30, 2024

emcbot commented Oct 30, 2024

emcbot commented Oct 30, 2024

emcbot commented Oct 31, 2024

RussTreadon-NOAA commented Nov 5, 2024

RussTreadon-NOAA commented Nov 15, 2024

RussTreadon-NOAA commented Nov 15, 2024

RussTreadon-NOAA commented Nov 15, 2024

DavidNew-NOAA left a comment

RussTreadon-NOAA commented Nov 15, 2024

Update JEDI hashes to include Model Variable Renaming Sprint #1355

Update JEDI hashes to include Model Variable Renaming Sprint #1355

Conversation

RussTreadon-NOAA commented Oct 30, 2024 • edited Loading

emcbot commented Oct 30, 2024

emcbot commented Oct 30, 2024

emcbot commented Oct 30, 2024

emcbot commented Oct 31, 2024

RussTreadon-NOAA commented Nov 5, 2024

RussTreadon-NOAA commented Nov 15, 2024

RussTreadon-NOAA commented Nov 15, 2024

RussTreadon-NOAA commented Nov 15, 2024

DavidNew-NOAA left a comment

Choose a reason for hiding this comment

RussTreadon-NOAA commented Nov 15, 2024

RussTreadon-NOAA commented Oct 30, 2024 •

edited

Loading