Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new calendar #1372

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

Implement new calendar #1372

wants to merge 13 commits into from

Conversation

Process-ing
Copy link
Contributor

@Process-ing Process-ing commented Oct 26, 2024 •
edited
Loading

Closes #1275

Screenshot_1730026806

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@codecov Codecov
Copy link

codecov bot commented Oct 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11%. Comparing base (91b145c) to head (b1b34ed).
Report is 3 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #1372    +/-   ##
========================================
- Coverage       12%     11%    -0%     
========================================
  Files          264     265     +1     
  Lines         7238    7371   +133     
========================================
  Hits           803     803            
- Misses        6435    6568   +133

@Process-ing Process-ing requested a review from a team October 26, 2024 20:04
@Process-ing Process-ing changed the title Feature/new calendar Implement new calendar Oct 26, 2024
@Process-ing Process-ing enabled auto-merge October 26, 2024 20:34
thePeras
thePeras reviewed Nov 11, 2024
View reviewed changes
packages/uni_ui/lib/calendar/calendar_item.dart

static String monthToString(int month) {
// TODO: Support Portuguese
const strMonths = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #1379, I added a datetime extension method for this case. However, I think this parsing should be moved to uni_app, and just receive a string. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DGoiana DGoiana DGoiana left review comments

@thePeras thePeras thePeras left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calendar timeline
3 participants
@Process-ing @thePeras @DGoiana