removed profile pic and added an horizontal line to some pages #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DGoiana
reviewed
Aug 7, 2024
packages/uni_app/lib/view/common_widgets/pages_layouts/general/widgets/top_navigation_bar.dart
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ui/redesign #1294 +/- ##
===========================================
+ Coverage 12% 12% +1%
===========================================
Files 266 264 -2
Lines 7201 7208 +7
===========================================
+ Hits 806 808 +2
- Misses 6395 6400 +5
|
|
Looks good! To finalize, can we just give a little bit of opacity to the line, I think it is too dark. |
|
@clarapbsousa can you attach the final screenshots of the result? |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1268
The rightButton has been removed from home.dart, general.dart, and secondary.dart. Additionally, top_navigation_bar.dart has been updated to include an optional horizontal line below the title for pages titled "Faculty" or "Restaurants".
Review checklist
whatsnew/whatsnew-pt-PTchangelog.mdwith the change