You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
There is a corner case where if a report is submitted, then afterwards the approval flow is changed, the workflow may show incorrect information.
To Reproduce
Steps to reproduce the behavior:
make sure there's a default approval flow (should be the case in development with the default dataset)
log in as jack (of org EF 2.1, which has no approval workflow) and create a report
fill in all required fields, save the report and submit it
the workflow should state that the default approval flow applies
log in as arthur and make henry an approver for EF 2.1
log in as henry; who should have 0 reports pending his approval
still as henry, click on EF 2.1's reports in the last 7 days
the first report should be the one just created by jack; the workflow would appear to indicate that henry is the current approver
click Read report and see that there is no Approve button
Expected behavior
Since we probably don't want to change the workflow of an already submitted report post factum, the workflow display should take a report's approvalStepUuid into account. But how to integrate this into the way the workflow is determined (Report::loadWorkflow)? The report's approvalStepUuid will not be present in the computed workflow, so where in the workflow are we? Maybe we need to check whether the approvalStepUuid is part of the defaultOrg workflow, and in that case, don't use the advisorOrg workflow but use the defaultOrg workflow. Although that is getting complicated.
The text was updated successfully, but these errors were encountered:
Describe the bug
There is a corner case where if a report is submitted, then afterwards the approval flow is changed, the workflow may show incorrect information.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Since we probably don't want to change the workflow of an already submitted report post factum, the workflow display should take a report's
approvalStepUuid
into account. But how to integrate this into the way the workflow is determined (Report::loadWorkflow
)? The report'sapprovalStepUuid
will not be present in the computed workflow, so where in the workflow are we? Maybe we need to check whether theapprovalStepUuid
is part of the defaultOrg workflow, and in that case, don't use the advisorOrg workflow but use the defaultOrg workflow. Although that is getting complicated.The text was updated successfully, but these errors were encountered: