-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asset 504: bad answer ID for thrombin, duplicate of 503? #84
Comments
This means there's some vagueness around what thrombin is (F2 gene/multiple proteins/chemical thing). Alpha-thrombin |
Running thrombin through Name Resolver gives |
I don't think this query will return chemicals as "answers". The query seems to be an MVP2 with the input chemical (Lepirudin), so the output would be genes with decreased activity/abundance. |
Sorry - I am just coming back to this (I was away for quite some time). For all assets I have done, the ID reported was the IDs outputed by the UI. I did this on purpose because issues in normalization need to be adressed as well. So to me, they should raise other tests for nomalization issues. If we fix them by hand here, will we be able then to come back and list all issues in normalization for another suite? |
Assets 503 and 504 are not duplicates, they are "unconflated" results: because of conflation, they are all top answers but in reality they are different elements: There is an issue with output nomalization that leads to 2 different results (from different ARAs) that are both true, they just appear in 2 different clique. Please note that Thombin is a serine protease so it is not a compound but a protein and with conflation on, F2/Thombin/Prothrombin are all true. |
Please assign this email address/GitHub account in the future, I do not receive any notification with the other one. Thanks! |
Asset 504 currently uses CHEMBL.COMPOUND:CHEMBL2108110 as the expected answer ID for thrombin.
However, this is a chemical ID - and this appears to be looking for genes that have decreased activity/abundance with the input chemical Lepirudin.
I imagine the gene/protein ID should be used instead - but then this is the same as Asset 503 (which has another issue #83).
Should this test be removed as a duplicate?
The text was updated successfully, but these errors were encountered: