Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Blocklist to be a map which includes a human-readable name #627

Closed
MarkDWilliams opened this issue Jun 5, 2024 · 1 comment
Closed
Assignees

Comments

@MarkDWilliams
Copy link
Collaborator

MarkDWilliams commented Jun 5, 2024

Currently, the blocklist is only identifiers. As it grows, this may become harder to wrangle. Recommending that we change it to a map from id->name and just use the .keys() in place of the whole list in the remove_blocked() method

@MarkDWilliams
Copy link
Collaborator Author

To do this, you'll need to write a one off script to go through the blocklist.json, node norm it, get the preferred names, and then output a dictionary that maps the CURIE to the preferred label from node norm. Our blocklist code would work as is, but now on just blocklist.keys(). It won't need the names; those are just for human readability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants