Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to handle constraints? #37

Open
cbizon opened this issue Jun 22, 2021 · 4 comments
Open

Update to handle constraints? #37

cbizon opened this issue Jun 22, 2021 · 4 comments
Assignees

Comments

@cbizon
Copy link
Collaborator

cbizon commented Jun 22, 2021

Where should constraints go? Is it an option on our fill/bind operations? Subclasses thereof? Does everybody have to match the constraint? What if the tool lacks the data (like a node property) on which to perform the constraint?

@cbizon
Copy link
Collaborator Author

cbizon commented Jun 22, 2021

After discussing on the O&W call, we agreed to add a post-condition to fill that constraints be honored in any result.

@dkoslicki
Copy link
Member

Will need to write up code snippets here that validates all constraints are satisfied (properties, categories, etc.).
Patrick estimates doable, but not simple

@dkoslicki
Copy link
Member

Perhaps just say: "Any constraints specified in the TRAPI must be respected by fill/lookup" in the description of the operation

@finnagin
Copy link
Contributor

TODO: add "Any constraints specified in the TRAPI must be respected by fill/lookup" to the descriptions of fill, lookup, & lookup_and_score in a new PR

finnagin added a commit to finnagin/OperationsAndWorkflows that referenced this issue Mar 8, 2022
finnagin added a commit to finnagin/OperationsAndWorkflows that referenced this issue Mar 8, 2022
finnagin added a commit to finnagin/OperationsAndWorkflows that referenced this issue Mar 8, 2022
finnagin added a commit to finnagin/OperationsAndWorkflows that referenced this issue Mar 8, 2022
finnagin added a commit to finnagin/OperationsAndWorkflows that referenced this issue Mar 9, 2022
finnagin added a commit to finnagin/OperationsAndWorkflows that referenced this issue Mar 9, 2022
finnagin added a commit to finnagin/OperationsAndWorkflows that referenced this issue Mar 9, 2022
finnagin added a commit to finnagin/OperationsAndWorkflows that referenced this issue Mar 9, 2022
finnagin added a commit that referenced this issue Mar 9, 2022
finnagin added a commit that referenced this issue Mar 9, 2022
finnagin added a commit that referenced this issue Mar 9, 2022
finnagin added a commit that referenced this issue Mar 9, 2022
finnagin added a commit that referenced this issue Mar 9, 2022
finnagin added a commit that referenced this issue Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants