-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
subgraphs of subgraphs look like duplicate paths - why do we represent the same paths multiple ways? #907
Comments
I can confirm that BTE places the inferred edge @sstemann is talking about both at the analysis level and as a supporting edge for the other inferred edge. It definitely seems redundant. @andrewsu @colleenXu |
I think there's an issue with self-edges happening here. I'm looking at the BTE response in ARAX-CI UI: On the top-level, there's two edges with subgraphs. The bottom edge's support-graph has spastic diplegia, which matches the top red line in Sarah's screenshot. The top edge's support-graph at first glance doesn't have spastic diplegia at all. But if I look at the "phenotype_of" self-edge, it has a bunch of support-graphs. I bet the "duplicate/repetitiveness" is coming from that. The ARAX-UI doesn't show these deeper support-graphs so I didn't verify this yet. @tokebe I thought we dealt with self-edges back in biothings/biothings_explorer#734? |
Tracking in biothings/biothings_explorer#850. I thought we had dealt with this already as well. I'll investigate further. |
HOLD ON: I now wonder if the bottom "spastic diplegia" path could actually be coming from Aragorn. AKA "duplicate" spastic diplegia paths in the UI isn't actually due to the BTE's data having self-edges. @cbizon @sstemann @gprice1129 I can't see Aragorn's response in the ARAX-CI UI, but I can look in the JSON. Adrenal Cortex Hormones (MESH:D000305) is actually the 5th result in Aragorn's response. The "on" ID is actually for spastic diplegia (MONDO:0001167), with the query_id set to cerebral palsy (MONDO:0006497)
The result's bound-edge `ef6edd43b0c8` is adrenal cortex hormones "treats_or_..." spastic diplegia from semmeddb <- rtx-kg2, with 12 publications
It seems odd that the 5th result from Aragorn wouldn't be in the ARS/UI - especially if BTE's corresponding result (# 78) is. Links: |
As for the first part of @sstemann's opening post: there's both an "inferred" treats and an "inferred" treats_or_applied... because of BTE's behavior. This is now addressed in BTE-CI - it'll just be "inferred" treats (fix deployed Aug 14th ~9:20 AM pacific time). |
@colleenXu have you verified that the issue is coming from ARAGORN? I don't think that is the case because it is not included as a source on either inferred edge. |
Well there's been no reply here from Aragorn folks (or ARS folks) on the situation I proposed. In that situation, I think the provenance info was lost somehow. I'm reminded of #776 (comment), although that was something different. I suspect it isn't BTE self-edges because I saw other cases of BTE self-edges here and didn't see the same "duplicate paths" problem in the UI. I imagine it'd be worth it to rerun this query and see how things look. A "self-edge" fix is live in BTE-CI as of yesterday/BTE-Test as of today...in case it is from BTE. |
Note that the BTE self-edges issue has been resolved and deployed to Prod, tangential as it is to this issue. Additionally, BTE direct edge handling has been fixed on Prod (re: this comment) |
You can try to use the screenshots below but it really is something to experience for yourself
https://ui.test.transltr.io/main/results?l=Cerebral%20Palsy&i=MONDO:0006497&t=0&r=0&q=1d5ed830-1455-40d8-b0e1-31e7851ef547
Expand Adrenal Cortex Hormones
Notice the first inferred path - two edges, two different predicates, one ARA
Notice the support path of the second inferred path LOOKS duplicative of the second from the bottom support path of the first inferred path
The Evidence on the edges looks the same -
Do we need all of these paths?
The text was updated successfully, but these errors were encountered: