-
Notifications
You must be signed in to change notification settings - Fork 64
CCPP Framework Meeting Minutes 2024 06 06
Courtney Peverley edited this page Jun 6, 2024
·
3 revisions
Attendees: Mike Kavulich,
CCPP Framework (issues, PRs, discussions)
- Constituent updates #549
-
Edge case for "none" unit conversions Issue#567
- Should be straightforward to fix.
-
Remove requirement that suite definition file names begin with "suite_" PR#569
- Waiting on downstream testing/acceptance
Standard names (issues, PRs, discussions)
-
Add water variables PR#69
- Thanks Jesse for getting this merged, sorry to drop the ball on that
CCPP Framework
- Constituent updates (#549)
- Waiting to be added to UFS PR - hopefully early next week
- Also needs official approval from Steve, or possibly will override if he doesn’t approve (Dom to look at repo settings)
- “None” vs “none” edge case
- Courtney to open PR once we have a development branch - probably change “none” to lowercase before comparison happens
- Remove requirement that SDF file name begins with “suite_”
- Held up by upstream PRs that need to be opened
Discussion
- New CCPP register phase?
- Grant - used to have ccpp_init phase in prebuild that initializes data structures, etc
- Dom - as long as you’re not passing around data, it should be ok to have a phase that is set up the same as the other, existing phases
- May also want a more formal framework init phase
- Dustin - where would this be called from the host?
- Jesse - has to be before the dycore
- Dom - can implement init phase in UFS that calls the new phase before the call to the dycore
- Context from NCAR side:
- We need some way of initializing constituents at runtime, but it needs to happen before the dycore is initialized
- Dom - internal field table NML (similar to internal namelist object)? Read once at beginning and then passed around.
- Grant - field table redundant?
- Michael K - we’ll keep the discussion ongoing, need to discuss details and specifics
- Jesse - a full new phase would be “easiest” to understand
- NCAR folks can try to make an example of this phase and open as a draft PR?
- General agreement
- NCAR folks can try to make an example of this phase and open as a draft PR?
- Cheryl - what would we want the name to be? Pre-init? Register?
- Dustin votes “register”
- Dom - suggests NCAR folks write simple proposal
- What it’s needed for, super-high-level design
- Run it by Steve, etc and then implement small test case
- What it’s needed for, super-high-level design