-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REMAP_VEL_CONSERVE_KE breaks dimensional consistency tests #300
Comments
OK, I will take a look. |
I can't get dev/ncar to pass dimensional consistency even with |
I think the lines that break the dimensional consistency tests are here and here. The correction is based on the square root of the ratio of two kinetic energies, and to avoid division by 0 I introduced a dimensional constant 1.E-19. This literal constant doesn't scale in the dimensional consistency tests, which causes the results to change and the test to fail. I changed the code to remove the literal constant here and here. Separately, on the same branch I also changed the computation of the diagnostics |
This issue was resolved by #308. |
@alperaltuntas found that the dimensional consistency tests break when
REMAP_VEL_CONSERVE_KE = True
.CC'ing @iangrooms
The text was updated successfully, but these errors were encountered: