Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An analysis graph is generated by selecting a part of the map that does not have a layer, after selecting one that does have a layer. #396

Closed
Catalina-Moller opened this issue Dec 21, 2022 · 2 comments

Comments

@Catalina-Moller
Copy link

Catalina-Moller commented Dec 21, 2022

Description:

When the user generates an analysis and then modifies the area of the map by selecting an area that is not covered by a layer, he gets the graph he saw before making the modification.

Steps to reproduce it:

  1. The user selects a part of the map that has a covering layer, a date range and a layer.
  2. Presses the "Generate" button.
  3. The analysis graph is generated.
  4. Presses the "Refine" button.
  5. The edit page is displayed and the user selects a part of the map that does not have a layer covering it.
  6. Click the "Generate" button.
  7. The same graph of the analysis that the user saw previously (point 3.) is generated.

Acceptance criteria:

When the user selects a portion of the map that is not covered by any layers, the user should not be able to see a generated graph.
The user should either see an appropriate error message or simply not be able to select a layer in a portion of space that does not have any.

To generate the evidence we used the Analysis section of the Agriculture area and generated the graphs with the "GEOGLAM Crop Conditions" dataset.

EVIDENCE: Video

@danielfdsilva
Copy link
Collaborator

This is a data api problem. The api returns the dataset when making a request in the analysis define page, but it shouldn't.
Assuming this will be addressed once the collection search endpoint is implemented.

cc @j08lue @anayeaye

@j08lue
Copy link
Contributor

j08lue commented Oct 9, 2023

Valid UX improvement opportunity for the current Analysis feature. This was also touched upon in the context of this ticket:

But this flow is going away in the new E&A user flow, where the user selects datasets/collections first and can see on map and time line whether the collection has data in their time range / area of interest.

So I guess we can close this - generously as completed.

@j08lue j08lue closed this as completed Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants