Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SiteAlert and Banner icons not shown in the GHG Center #1373

Closed
dzole0311 opened this issue Jan 14, 2025 · 0 comments · Fixed by #1378
Closed

SiteAlert and Banner icons not shown in the GHG Center #1373

dzole0311 opened this issue Jan 14, 2025 · 0 comments · Fixed by #1378
Assignees
Labels
veda v2 VEDA Refactor Epic Work

Comments

@dzole0311
Copy link
Collaborator

The USWDS icons are not shown when the SiteAlert or the Banner are used in the GHG center.

See: US-GHG-Center/veda-config-ghg#693

@dzole0311 dzole0311 added the veda v2 VEDA Refactor Epic Work label Jan 14, 2025
@dzole0311 dzole0311 self-assigned this Jan 14, 2025
dzole0311 added a commit that referenced this issue Jan 15, 2025
**Related Ticket:** closes
#1373

### Description of Changes
The gulp task for copying the USWDS assets during deployment was not
copying the assets at all. I've updated the task by replacing the
generic `uswds.copyImages()` function with an explicit gulp task

### Notes & Questions About Changes
- The change follows the same pattern as other copy tasks in our
gulpfile
- No other configuration changes are needed as the task is already used
into the existing build process

### Validation / Testing
- In the deploy preview for veda-ui and veda-config-ghg (PR with
deployment: US-GHG-Center/veda-config-ghg#698),
verify that USWDS icons appear correctly in the `SiteAlert` or `Banner`
components
- Check if the icons appear when running the veda-ui locally
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
veda v2 VEDA Refactor Epic Work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant