Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new Banner should follow markdown configuration for the content #1348

Closed
1 task
dzole0311 opened this issue Dec 20, 2024 · 0 comments
Closed
1 task

The new Banner should follow markdown configuration for the content #1348

dzole0311 opened this issue Dec 20, 2024 · 0 comments
Assignees
Labels
veda v2 VEDA Refactor Epic Work

Comments

@dzole0311
Copy link
Collaborator

Context

The new USWDS Banner accepts content as a string. The content can also be html, which is then decoded by the component to render the appropriate html tags. To stay aligned with some of the other veda components, we should adjust this to accept markdown configuration instead (e.g. ::markdown).

See thread here: #1328 (comment)

Acceptance Criteria

  • Adjust the configuration for the Banner to accept markdown content

Related Tickets

[If applicable, link any tickets that are related]

@dzole0311 dzole0311 added the veda v2 VEDA Refactor Epic Work label Dec 20, 2024
@dzole0311 dzole0311 self-assigned this Jan 2, 2025
dzole0311 added a commit that referenced this issue Jan 7, 2025
…der dependency (#1355)

**Related Ticket:** #1348

### Description of Changes
- Remove the HTML encoder dependency
- Updated `SiteAlert` and `Banner` mocks to use markdown syntax, which
is parsed via Parcel

### Notes & Questions About Changes
_{Add additonal notes and outstanding questions here related to changes
in this pull request}_

### Validation / Testing
1. Tweak the content for the SiteAlert or the Banner in the the
configuration file using markdown syntax for their content / text
2. Restart your build process (`yarn clean` may be needed)
3. Check that the changes are correctly displayed in the banner or site
alert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
veda v2 VEDA Refactor Epic Work
Projects
None yet
Development

No branches or pull requests

1 participant