-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change CMR DataFormat to "COG" #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, nice work! I had a couple questions for my own understanding, but nothing to change except maybe a leftover debugging line of code? I could just be missing how it relates to the code comment though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for answering my "am I following" questions!
Thanks for your keen eyes @ceholden. Looks like you'll need to re-approve after my last change to remove the errant commented-out code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1!
Sorry I thought I reapproved! Thanks for tagging me again
Oh, weird. Still saying I'm blocked. Let me look at the settings. |
Ah! I had to add you to the maintainer list. |
@sharkinsspatial, this ended up only updating DataFormat to "COG", and nothing else. Can we book time with you, Chris, and myself for you to show us how you update the pipeline to pull in this change? |
Fixes #40