Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CMR DataFormat to "COG" #42

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Change CMR DataFormat to "COG" #42

merged 2 commits into from
Nov 7, 2024

Conversation

chuckwondo
Copy link
Collaborator

Fixes #40

Copy link
Collaborator

@ceholden ceholden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, nice work! I had a couple questions for my own understanding, but nothing to change except maybe a leftover debugging line of code? I could just be missing how it relates to the code comment though

setup.py Show resolved Hide resolved
hls_vi/generate_metadata.py Outdated Show resolved Hide resolved
@chuckwondo chuckwondo requested a review from ceholden November 6, 2024 21:41
Copy link
Collaborator

@ceholden ceholden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for answering my "am I following" questions!

@chuckwondo chuckwondo requested a review from ceholden November 7, 2024 12:16
@chuckwondo
Copy link
Collaborator Author

Thanks for your keen eyes @ceholden. Looks like you'll need to re-approve after my last change to remove the errant commented-out code.

Copy link
Collaborator

@ceholden ceholden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1!

Sorry I thought I reapproved! Thanks for tagging me again

@chuckwondo
Copy link
Collaborator Author

Oh, weird. Still saying I'm blocked. Let me look at the settings.

@chuckwondo
Copy link
Collaborator Author

Ah! I had to add you to the maintainer list.

@chuckwondo chuckwondo merged commit dfdddc4 into main Nov 7, 2024
1 check passed
@chuckwondo
Copy link
Collaborator Author

@sharkinsspatial, this ended up only updating DataFormat to "COG", and nothing else. Can we book time with you, Chris, and myself for you to show us how you update the pipeline to pull in this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HLS-VI: Needed metadata updates
2 participants