Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct AssociatedBrowseImageUrls #27

Closed
chuckwondo opened this issue Jul 15, 2024 · 1 comment · Fixed by #28
Closed

Correct AssociatedBrowseImageUrls #27

chuckwondo opened this issue Jul 15, 2024 · 1 comment · Fixed by #28
Assignees
Labels
bug Something isn't working

Comments

@chuckwondo
Copy link
Collaborator

The URLs in the XML metadata files are incorrect, as they are simply copied from the original HLS metadata.

In tests/fixtures/HLS-VI.S30.T13RCN.2024128T173909.v2.0.cmr.xml, we have this:

  <AssociatedBrowseImageUrls>
    <ProviderBrowseUrl>
      <URL>https://data.lpdaac.earthdatacloud.nasa.gov/lp-prod-public/HLSS30.020/HLS.S30.T13RCN.2024128T173909.v2.0/HLS.S30.T13RCN.2024128T173909.v2.0.jpg</URL>
      <Description>Download HLS.S30.T13RCN.2024128T173909.v2.0.jpg</Description>
    </ProviderBrowseUrl>
    <ProviderBrowseUrl>
      <URL>s3://lp-prod-public/HLSS30.020/HLS.S30.T13RCN.2024128T173909.v2.0/HLS.S30.T13RCN.2024128T173909.v2.0.jpg</URL>
      <Description>This link provides direct download access via S3 to the granule</Description>
    </ProviderBrowseUrl>
  </AssociatedBrowseImageUrls>

In tests/fixtures/HLS-VI.L30.T06WVS.2024120T211159.v2.0.cmr.xml, the AssociatedBrowseImageUrls is empty, and it is also empty in the original HLS metadata file tests/fixtures/HLS.L30.T06WVS.2024120T211159.v2.0/HLS.L30.T06WVS.2024120T211159.v2.0.cmr.xml.

@madhuksridhar, do the L30 metadata files not contain such URLs?

@chuckwondo chuckwondo added the bug Something isn't working label Jul 15, 2024
@chuckwondo chuckwondo self-assigned this Jul 15, 2024
@chuckwondo
Copy link
Collaborator Author

After chatting with @madhuksridhar, we will simply remove the URLs from the metadata fixture files, as Cumulus should be the one to populate them during ingestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant