Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLS VI: Add CMR STAC generation capabilities #13

Closed
madhuksridhar opened this issue Apr 15, 2024 · 8 comments
Closed

HLS VI: Add CMR STAC generation capabilities #13

madhuksridhar opened this issue Apr 15, 2024 · 8 comments
Assignees

Comments

@madhuksridhar
Copy link
Collaborator

No description provided.

@SwordSaintLancelot
Copy link

Here is the script to create the STAC item. @chuckwondo I simply created a class and have not made a lot of changes yet. We can look at it together once we are ready to create the item.

@Jeaton1021
Copy link

Waiting on Chuck to review next week before closing out.

@chuckwondo
Copy link

@SwordSaintLancelot, some major refactoring has landed on the main branch, which moves/renames a number of things, most importantly the package folder, which changed from hls-vi to hls_vi because hls-vi is not a valid Python package name (dashes are not permitted).

You might simply want to create a new branch off of main and then copy your hls_stac_item.py file over to the new branch you create. Then, I suggest you eliminate the HlsViStacItem class and simply convert all of its methods into functions. There's no need for a class in this case.

@SwordSaintLancelot
Copy link

Thanks for the heads up @chuckwondo . I will rebase the branch and work on getting the functions changed.

@chuckwondo
Copy link

@SwordSaintLancelot, I suggest simply creating a new branch off of main. Rebasing will likely be very problematic due to the significant number of moves/renames.

@chuckwondo
Copy link

Fixed by NASA-IMPACT/hls-vi#21

@madhuksridhar
Copy link
Collaborator Author

@SwordSaintLancelot can we close this ticket?

@SwordSaintLancelot
Copy link

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants