Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL page filters #1144

Closed
dhanur-sharma opened this issue Dec 13, 2024 · 1 comment · Fixed by #1145
Closed

Fix URL page filters #1144

dhanur-sharma opened this issue Dec 13, 2024 · 1 comment · Fixed by #1145
Assignees

Comments

@dhanur-sharma
Copy link

Description

The filters for Exclude and Deleted are not functioning as expected, and need to be rectified. The Deleted filter is still controlling the Excluded column and should allow independent filtering.

Implementation Considerations

  • Ensure that the filter is functional for Delete on the URLs page.
  • Do not disturb the other filters.

Deliverable

Functional filter for Delete on the URLs page.

Dependencies

No response

@dhanur-sharma dhanur-sharma self-assigned this Dec 13, 2024
@dhanur-sharma
Copy link
Author

The filter now works as expected. It functions like an AND would, so if we select Excluded=True and Deleted=False, the page would display the excluded URLs that are not deleted.

No filter:
Image

Deleted=False:
Image

Deleted=True:
Image

Excluded=True AND Deleted=False:
Image

Excluded=True AND Deleted=True:
Image

Excluded=False AND Deleted=False:
Image

Excluded=False AND Deleted=True:
Image

@dhanur-sharma dhanur-sharma linked a pull request Dec 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant