Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code climate base checks dont run on .inc files #120

Open
bradfordcondon opened this issue Jan 15, 2019 · 3 comments
Open

code climate base checks dont run on .inc files #120

bradfordcondon opened this issue Jan 15, 2019 · 3 comments
Labels
documentation enhancement New feature or request

Comments

@bradfordcondon
Copy link
Contributor

screen shot 2019-01-15 at 1 19 47 pm

as you can see the sniffing/reading of the code isnt right. i think the code coverage reporting is still correct.
@bradfordcondon
Copy link
Contributor Author

I think this is from the custom code climate config file not specifying hte maintainability tests should be added.

it says they are enabled by default, but lets try enabling everything:

checks:
  argument-count:
    enabled: true
  complex-logic:
    enabled: true
  file-lines:
    enabled: true
  method-complexity:
    enabled: true
  method-count:
    enabled: true
  method-lines:
    enabled: true
  nested-control-flow:
    enabled: true
  return-statements:
    enabled: true
  similar-code:
    enabled: true
  identical-code:
    enabled: true

@bradfordcondon
Copy link
Contributor Author

these exclude patterns make sense to me... but, we dont have any files analyzed whatsoever.

exclude_patterns:
   - "docs/"
   - "examples/"
   - "mappings/"
   - "tests/"
   - "!**/*.inc"
``

@bradfordcondon bradfordcondon self-assigned this Feb 8, 2019
@bradfordcondon
Copy link
Contributor Author

bradfordcondon commented Feb 8, 2019

I cant find documentation on tihs. The metrics only run for canonical extensions (.py, .php). I don't know how to get them to run for .inc. thats the problem. they run by default, no need for the checks configuration- unless theres some place to set teh file patterns there.

perhaps qltysh/qlty#662 (comment) ?

@bradfordcondon bradfordcondon added enhancement New feature or request documentation labels Feb 8, 2019
@bradfordcondon bradfordcondon changed the title code climate integration messed up code climate base checks dont run on .inc files Feb 8, 2019
@bradfordcondon bradfordcondon removed their assignment Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant