From 4e4ab017d3c135a78302b2bba560b10b602399ee Mon Sep 17 00:00:00 2001 From: Christoph Backhaus <106314951+NADOOITChristophBa@users.noreply.github.com> Date: Wed, 27 Nov 2024 15:25:03 +0100 Subject: [PATCH] Properly escape variables in ssh commands to fix ShellCheck warnings --- ssl_manager.sh | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/ssl_manager.sh b/ssl_manager.sh index ff49a9c..c0231d1 100755 --- a/ssl_manager.sh +++ b/ssl_manager.sh @@ -15,26 +15,26 @@ setup_ssl() { # Configure Nginx for domain echo -e "\n⚙️ Configuring Nginx for $domain..." - ssh "$admin_user@$server_ip" "sudo bash -c 'cat > /etc/nginx/sites-available/\\$domain << EOF + ssh "$admin_user@$server_ip" "sudo bash -c 'cat > /etc/nginx/sites-available/'\"\$domain\"' << EOF server { listen 80; - server_name \\\$domain www.\\\$domain; + server_name '\"\$domain\"' www.'\"\$domain\"'; location / { proxy_pass http://localhost:8000; - proxy_set_header Host \\\$host; - proxy_set_header X-Real-IP \\\$remote_addr; + proxy_set_header Host \$host; + proxy_set_header X-Real-IP \$remote_addr; } } EOF'" - + # Enable site - ssh "$admin_user@$server_ip" "sudo ln -sf /etc/nginx/sites-available/\\$domain /etc/nginx/sites-enabled/" + ssh "$admin_user@$server_ip" "sudo ln -sf /etc/nginx/sites-available/'\"\$domain\"' /etc/nginx/sites-enabled/" ssh "$admin_user@$server_ip" "sudo nginx -t && sudo systemctl reload nginx" # Get SSL certificate echo -e "\n🔑 Obtaining SSL certificate..." - ssh "$admin_user@$server_ip" "sudo certbot --nginx -d \\\$domain -d www.\\\$domain --non-interactive --agree-tos --email christoph.backhaus@nadooit.de" + ssh "$admin_user@$server_ip" "sudo certbot --nginx -d '\"\$domain\"' -d www.'\"\$domain\"' --non-interactive --agree-tos --email christoph.backhaus@nadooit.de" # Setup auto-renewal cron job echo -e "\n⏰ Setting up automatic renewal..."