Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TreePiece::sort() entry method to replace TreePiece::drift(0.0...) #182

Open
trquinn opened this issue Aug 8, 2024 · 0 comments
Open
Labels

Comments

@trquinn
Copy link
Member

trquinn commented Aug 8, 2024

There is at least 10 times in the code where we call treeProxy.drift(0.0...) when we just want to get the particles into tree order. This involves an unnecessary pass over the particles, a reduction, and a broadcast. I suggest adding a new entry method that performs the core of TreePiece::assignKeys(). Note that it must assume that nobody has messed with TreePieces::boundingBox, but I don't think that is an issue.

@trquinn trquinn added the cleanup label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant