MythV4L2M2MContext: Prepare for planned V4L2 Request API hwaccel changes #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FFmpeg internal V4L2RequestDescriptor type is not meant to be used by applications, instead applications should treat the returned frames as if a AVDRMFrameDescriptor was returned, as defined by the DRM_PRIME pix fmt. Remove the custom implementation of GetRequestBuffer and use the base GetDRMBuffer function instead. Signed-off-by: Jonas Karlman <[email protected]>
av_hwdevice_ctx_init() is already called internally by FFmpeg function av_hwdevice_ctx_create(), and is not meant to be called a second time. Remove the unneeded av_hwdevice_ctx_init() to simplify the code. Signed-off-by: Jonas Karlman <[email protected]>
|
Jonas,
So i would say: great work! |
This was referenced Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some changes that should help prepare for planned V4L2 Request API hwaccel changes.
Please note that I have not compile or runtime testes these changes, @warpme please help test these changes.
Checklist