Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expire pairing credentials #197

Open
leto opened this issue Sep 9, 2020 · 0 comments
Open

Expire pairing credentials #197

leto opened this issue Sep 9, 2020 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@leto
Copy link
Member

leto commented Sep 9, 2020

It seems that pairing credentials do not expire. I connected SDA to SD after about 2 weeks, and it successfully connected with the same pairing code.

This might be seen as a feature, but it's a bug. If somebody steals your pairing code, they can use it indefinitely.

These pairing codes should expire after a short time. Very few users do anything but generate them and scan them a few minutes later. Expiring within 1 day should be reasonable, with potentially an advanced option to change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant