Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor refreshing ztx confirmations #194

Open
leto opened this issue Sep 5, 2020 · 0 comments
Open

Refactor refreshing ztx confirmations #194

leto opened this issue Sep 5, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@leto
Copy link
Member

leto commented Sep 5, 2020

The current code for refreshing confirmation counts for ztx's is extremely inefficient, it does a gettransaction call on every single ztx in the history of the wallet, to update the current confirmations count. No user actually cares about the conf count, except to know if it's unconfirmed, confirmed or notarized.

So we are spending a massive amount of CPU every few seconds, slowing down the GUI, in wallets with many transactions.

A better GUI would show simply unconfirmed/confirmed/notarized, and only when viewing individual transaction details would we show exact confirmation counts. In my experience, users do not care about the confirmation counts of old transactions at all. We should not slow down our GUI rendering them all the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant