Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timing Per Analyzer #125

Open
Noggog opened this issue Sep 20, 2024 · 2 comments
Open

Timing Per Analyzer #125

Noggog opened this issue Sep 20, 2024 · 2 comments
Labels
engine A feature for the analyzer engine itself optimization

Comments

@Noggog
Copy link
Member

Noggog commented Sep 20, 2024

Add mechanisms to report timing of each analyzer being run

@Noggog Noggog added the engine A feature for the analyzer engine itself label Sep 20, 2024
@Noggog Noggog self-assigned this Oct 11, 2024
@Noggog Noggog removed their assignment Oct 27, 2024
@Elscrux
Copy link
Member

Elscrux commented Oct 29, 2024

Needs some thoughts because we currently don't really have any info that we get about the analyzer itself, we just report topics out of the analyzer if applicable. So I think there would need to be a new system that various drivers would call into which can be extended with various functionality like a time keeping feature. Or is this too open and we actually just need it for this one feature and nothing else?
The question would also be how we deal with the resulting data, how we expose it to outside sources in case they might be interested etc.

@Noggog
Copy link
Member Author

Noggog commented Oct 31, 2024

I was thinking that we'd just have an upgrade to the engine where it reports that it's starting to run an analyzer, and when it's done running that same analyzer. (would probably be necessary for UI display, too). This would be separate from the topic reporting pipeline mechanisms. It wouldn't attach any extra metadata (at least in this first pass) other than some basics like what the analyzer type was, and maybe the record/mod in question it was being run on. The resulting mechanisms could then do some stopwatch timings and then print the average run time per analyzer type, for ex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine A feature for the analyzer engine itself optimization
Projects
None yet
Development

No branches or pull requests

2 participants