Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: revert if all message bridges fail #97

Merged
merged 8 commits into from
Oct 9, 2023
Merged

feat: revert if all message bridges fail #97

merged 8 commits into from
Oct 9, 2023

Conversation

sujithsomraaj
Copy link
Collaborator

solves #95

src/MultiBridgeMessageSender.sol Outdated Show resolved Hide resolved
src/libraries/Error.sol Outdated Show resolved Hide resolved
@@ -102,6 +102,9 @@ library Error {
/// @dev is thrown if contract call is invalid (for axelar)
error NOT_APPROVED_BY_GATEWAY();

/// @dev is thrown if all message bridges fail
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// @dev is thrown if all message bridges fail
/// @dev is thrown if a message could not be sent through a sufficient number of bridges

test/unit-tests/MultiBridgeMessageSender.t.sol Outdated Show resolved Hide resolved
src/MultiBridgeMessageSender.sol Outdated Show resolved Hide resolved
test/unit-tests/MultiBridgeMessageSender.t.sol Outdated Show resolved Hide resolved
test/unit-tests/MultiBridgeMessageSender.t.sol Outdated Show resolved Hide resolved
src/MultiBridgeMessageSender.sol Show resolved Hide resolved
test/Setup.t.sol Show resolved Hide resolved
src/MultiBridgeMessageSender.sol Outdated Show resolved Hide resolved
uint256 _nativeValue,
uint256 _expiration,
address _refundAddress,
uint256[] calldata _fees,
address[] calldata _excludedAdapters
uint256[] memory _fees,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uint256[] memory _fees,
uint256[] calldata _fees,

@sujithsomraaj sujithsomraaj requested a review from ermyas October 9, 2023 01:17
@ermyas ermyas merged commit 0575e02 into main Oct 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants