Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

popperHideOnScroll not working on mobile devices #113

Open
hardcoreguru opened this issue Feb 18, 2019 · 9 comments
Open

popperHideOnScroll not working on mobile devices #113

hardcoreguru opened this issue Feb 18, 2019 · 9 comments
Assignees
Labels

Comments

@hardcoreguru
Copy link

i am using version 5.1.7.
I have tried even setting manually
[popperHideOnScroll] = "false"

but yet on mobile when i try to scroll the page the popper closes. On desktop no problem. Seems like on android/iphone the event is considered as click outside instead of swiping/scrolling

@MrFrankel
Copy link
Owner

@hardcoreguru can you try version 6.1.2-beta? let me know if it works

@MrFrankel MrFrankel self-assigned this Feb 20, 2019
@MrFrankel MrFrankel added the bug label Feb 20, 2019
@victorcamargos
Copy link

Had the same issue, tried 6.1.2-beta as suggested and it looks fine now.

@MrFrankel
Copy link
Owner

@victorcamargos ill get around to releasing 6.1.2 tomorrow.

@victorcamargos
Copy link

Hi @MrFrankel, thanks! Are you still planning on releasing 6.1.2 this week?

@MrFrankel
Copy link
Owner

@victorcamargos released 6.2.0.

@victorcamargos
Copy link

@MrFrankel, we installed 6.2.0 but the issue is still there. Could you please check and let me know when a new release could be done with the fix?

@Necroskillz
Copy link

Hi, why was this closed? the issue is still there on 6.2.0.

It works fine in 6.1.2-beta, but seems like it was broken again in 6.2.0 or the fix is not there. Please reopen.

@MrFrankel
Copy link
Owner

@Necroskillz, Sorry, iv’e done some clean up, if this is still relevant for you ill re open it, I try to get to it in the near future

@MrFrankel MrFrankel reopened this Jul 22, 2019
@victorcamargos
Copy link

Hi,
This is still not solved in 7.0.0 version.
We updated the solution to Angular 9 and need to keep using ngx-popper 6.1.2-beta because of this issue, hoping not to have any other issues with it in Angular 9.
Could you please remember to include the fix in next final version??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants