tech debt: launcher.settings vs launcher.config

[keturn]

There's o.t.launcher.settings.BaseLauncherSettings, with a note on it that says

@deprecated to be replaced by o.t.launcher.config.Config

But BaseLauncherSettings still shows up in a lot of places. The deprecation flag makes the tools tell me there's something wrong in the file I'm editing, and the duplication adds confusion and uncertainty to work like #560. The first place I tried to add a new validator didn't validate anything, because that validation class wasn't the one being used!

[keturn]

I was reminded of this while working in #571. I'm refactoring some stuff to get it out of ApplicationController, which I think is in alignment with other notes I've seen and things like #462, but it's also involved BaseLauncherSettings being in some of the methods I've extracted.

Does that make those new methods wrong, because they're using a deprecated class? I don't know. But I'm doing it because it's a safe refactoring and I know the right data is in there, because that's what's currently in use.

[skaldarnar]

I've removed the config package in #603, I think this can be closed.