Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate platform info into launcher #528

Open
jdrueckert opened this issue Mar 24, 2020 · 0 comments
Open

Integrate platform info into launcher #528

jdrueckert opened this issue Mar 24, 2020 · 0 comments
Assignees
Labels
Status: Actionable An issue or task that can immediately be worked on Type: Enhancement New features or noticable improvements.
Milestone

Comments

@jdrueckert
Copy link
Member

jdrueckert commented Mar 24, 2020

Currently, the launcher has no information about for which platform it was built. Thus, we cannot self-update as we don't know which asset to download. We need a way to integrate the information for which platform we build it into the launcher at build time so that the launcher can access that information on runtime.

Discussion result: the launcher is to detect OS and arch during startup

With this information, the self-updater can download the matching asset.
We do need to make very clear which OS and arch it updates to in the dialog(s) and logs, though.

@jdrueckert jdrueckert added Type: Enhancement New features or noticable improvements. Status: Actionable An issue or task that can immediately be worked on labels Mar 24, 2020
@jdrueckert jdrueckert added this to the v4.x.0 milestone Mar 24, 2020
@skaldarnar skaldarnar modified the milestones: v4.x.0, v4.1.0 Apr 1, 2020
@praj-foss praj-foss self-assigned this Apr 1, 2020
@skaldarnar skaldarnar modified the milestones: v4.1.0, v4.2.0 May 1, 2020
@skaldarnar skaldarnar modified the milestones: v4.2.0, v5.x Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Actionable An issue or task that can immediately be worked on Type: Enhancement New features or noticable improvements.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants