-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Internationalization/Locale Selection #31
Comments
@johnhanlon86 You don't need repo persmission to make a PR, is it? I didn't need for the PR I did yesterday. #107 (Correct me if I'm wrong.) |
Thanks @r3n3x , the error message is a response to an external API but I've updated the code so that we catch the API response for this specific message and translate. "Erro" is correct in this language/context. I'm still hitting an issue trying to push this up. Maybe you were given repo permissions at some stage whereas I'm missing permissions? |
@johnhanlon86 Try creating a branch from dev and push it.
|
Take a look at this repository and the pool request. Use it as an example. You need to create a fork in your repository and from there create a pool request to the current repository. |
To make the protocol as accessable as possible, we should add more languages for non-English speakers.
I have created a local branch that:
Updates the locale to be based on the user's prefered browser language (Chrome example below) with English as the fallback.
Adds a Brazilian Portuguese translation file. Below is production (left) versus my local branch (right).
I can push my branch and open a PR for your review if I have repo permission.
The text was updated successfully, but these errors were encountered: