Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Internationalization/Locale Selection #31

Open
johnhanlon86 opened this issue Feb 20, 2024 · 6 comments
Open

Update Internationalization/Locale Selection #31

johnhanlon86 opened this issue Feb 20, 2024 · 6 comments

Comments

@johnhanlon86
Copy link

To make the protocol as accessable as possible, we should add more languages for non-English speakers.

I have created a local branch that:

  1. Updates the locale to be based on the user's prefered browser language (Chrome example below) with English as the fallback.
    image

  2. Adds a Brazilian Portuguese translation file. Below is production (left) versus my local branch (right).

Morpheus Brazilian Portuguese Version

I can push my branch and open a PR for your review if I have repo permission.

@r3n3x
Copy link
Contributor

r3n3x commented Oct 25, 2024

@johnhanlon86 You don't need repo persmission to make a PR, is it?

I didn't need for the PR I did yesterday. #107
It's just that we'll need the maintainers to merge into MorpheusAIs:main then.

(Correct me if I'm wrong.)

@r3n3x
Copy link
Contributor

r3n3x commented Oct 25, 2024

Screenshot 2024-10-25 at 12 31 32 PM

The Error message misses on "R" in your local branch... And it's not translated into Portuguese.
Perhaps you can correct before you committ changes and then do merge PR.

@johnhanlon86
Copy link
Author

johnhanlon86 commented Oct 26, 2024

Thanks @r3n3x , the error message is a response to an external API but I've updated the code so that we catch the API response for this specific message and translate.

dashboard

"Erro" is correct in this language/context.

I'm still hitting an issue trying to push this up. Maybe you were given repo permissions at some stage whereas I'm missing permissions?

image

image

@Sorizen
Copy link
Collaborator

Sorizen commented Oct 29, 2024

@johnhanlon86 Try creating a branch from dev and push it.

git switch dev
git pull 
git switch -c feature/update-locale
git add . 
git commit -m "add update locale"
git push --set-upstream feature/update-locale

@johnhanlon86
Copy link
Author

I've tried that but I still get a similar message. The message mentions access rights so I think that if someone invites me as a collaborator, I'll be able to push up my branch and open a PR.

image

@FedokDL
Copy link
Collaborator

FedokDL commented Nov 5, 2024

Take a look at this repository and the pool request. Use it as an example.
#107

You need to create a fork in your repository and from there create a pool request to the current repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants