-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: ♻️ Use ForestStorageCaching
for BSPs
#281
Open
ffarall
wants to merge
19
commits into
main
Choose a base branch
from
feat/use-forest-storage-caching-for-bsps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… adding where `libpq.so` would be
snowmead
reviewed
Dec 9, 2024
…t write lock in submit proof task
…ce is large enough
ffarall
changed the title
reorg: ♻️ Use
refactor: ♻️ Use Dec 10, 2024
ForestStorageCaching
for BSPsForestStorageCaching
for BSPs
ffarall
requested review from
snowmead,
links234,
timbrinded and
undercover-cactus
December 11, 2024 02:25
timbrinded
reviewed
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
crossBuildMac
script to includelibpq.so
directory in linker paths.ForestStorageCaching
for BSPs, now that they will handle Forest Storage snapshots.provider_id
, that can either be a BSP or MSP ID.async
build()
so that they're able to run async functions when initialising.handle_initial_sync
was never called.Runnable
trait for StorageHub Builder toBuildable
.TODOs for other PRs: