New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"change" property conflicts with "change" methods #6

Open

mryellow opened this issue Aug 8, 2020 · 1 comment

Labels

bug

Collaborator

mryellow commented Aug 8, 2020 •

edited

Loading

Addition of change: Function property in Vue.mgComponent conflicts with methods called change which are used as event handlers.

Perhaps event handlers should always feature a Handler suffix. i.e. changeHandler.

ddefe31#diff-f5da0efe07b6a8ae1fd77554493d94d4R7147-R7149


found in

---> <MgChoiceDropdown>
       <MgWorkflow>
         <MgComponent>
           <MgContainer>
             <MgComponent>
               <MgContainer>
                 <MgComponent>
                   <MgForm>
                     <FormsEdit>
                       <Root>

Avoid mutating a prop directly since the value will be overwritten whenever the parent component re-renders. Instead, use a data or computed property based on the prop's value. Prop being mutated: "change"

The text was updated successfully, but these errors were encountered:

mryellow added the bug label

Collaborator Author

mryellow commented Aug 8, 2020

Commented out the change property for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment