Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming - footer deprecation warning #13

Open
janash opened this issue Mar 1, 2023 · 2 comments
Open

upcoming - footer deprecation warning #13

janash opened this issue Mar 1, 2023 · 2 comments

Comments

@janash
Copy link
Member

janash commented Mar 1, 2023

We currently use footer_items in conf.py, but it has a deprecation warning. We will need to update to use footer_start and footer_end.

https://pydata-sphinx-theme.readthedocs.io/en/stable/user_guide/layout.html#footer

@SinaMostafanejad
Copy link
Member

SinaMostafanejad commented Mar 3, 2023

Issue

The conf.py "footer_items": [ "molssi_footer" ] field in html_theme_options
dictionary is deprecated in PyData Sphinx Theme and MUST be
replaced with "footer_start": [ "molssi_footer" ] (and maybe "footer_end": [ "" ]) fields as described here.

Expected errors

The aforementioned change raises the following error at build time with sphinx-build

Extension error (pydata_sphinx_theme):
Handler <function update_config at 0x7ff683b89f30> for event 'builder-inited' threw an exception (exception: 'icon_links')
Makefile:53: recipe for target 'html' failed
make: *** [html] Error 2

Possible solutions

This post encourages using the autoapi.sphinx
extension or its variants but none seem to work.

@janash
Copy link
Member Author

janash commented Mar 3, 2023

Hi @SinaMostafanejad - this error is actually different than the deprecation warning. It has to do with icon_links in conf.py. I believe it is a bug that will probably be fixed in a patch of pydata sphinx theme soon.

Issues on main repo:

You can fix the error by either downgrading pydata-sphinx-theme, or by adding

    "icon_links": []

to html_theme_options

The footer_items field is actually still working for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants