Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle google_maps_api_key into repo #277

Open
emanuelb opened this issue Aug 9, 2020 · 0 comments
Open

Bundle google_maps_api_key into repo #277

emanuelb opened this issue Aug 9, 2020 · 0 comments

Comments

@emanuelb
Copy link

emanuelb commented Aug 9, 2020

Currently compiling android app require adding:

<?xml version="1.0" encoding="utf-8"?>
<resources>
    <string name="google_maps_api_key">GOOGLE_MAPS_API_KEY</string>
</resources>

to android/app/src/main/res/values/secrets.xml file.
But this won't help with reproducible-builds (which need the exact GOOGLE_MAPS_API_KEY value used for that version) and only make the build process require more steps.

As the AndroidManifest.xml require google_maps_api_key value

<meta-data
android:name="com.google.android.maps.v2.API_KEY"
android:value="@string/google_maps_api_key"
/>

I suggest to add it to the repo, in order to avoid needing to do the process below:

obtaining key from APK v2.2.6 below:

podman run --rm -ti docker.io/debian:sid
apt-get update; apt-get install --yes --no-install-recommends wget apktool;
wget https://github.com/MohGovIL/hamagen-react-native/releases/download/v2.2.6/hamagen-v2.2.6.apk
apktool d -s hamagen-v2.2.6.apk 
cat hamagen-v2.2.6/res/values/strings.xml | grep maps

which result in:

<string name="google_maps_api_key">AIzaSyBJzZETb4fOiGRokZFvm0c-ZvaSnz0Hia4</string>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant