Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two stage RESP fit #39

Open
kexul opened this issue Jul 17, 2020 · 3 comments
Open

Two stage RESP fit #39

kexul opened this issue Jul 17, 2020 · 3 comments
Assignees
@iwatobipen
Labels
question Further information is requested

Comments

@kexul
Copy link
Contributor

kexul commented Jul 17, 2020

Hi, As far as I know, the standard resp fit schedule need two steps fit. Here only one step was performed, is that enough?
@kzfm kzfm added the question Further information is requested label Jul 27, 2020
@kexul
Copy link
Contributor Author

kexul commented Aug 11, 2020

See #40

@iwatobipen
Copy link
Contributor

Sorry for my rate reply and thanks for your question. I'll check your PR ASAP.

@kexul
Copy link
Contributor Author

kexul commented Aug 17, 2020 •
edited
Loading

Though two stage fit was enforced now, there were some bugs in the code, see cdsgroup/resp#16 . And another important issue was, I don't know how to VERIFY the calculated value.
I calculated the charge for ethanol,
图片
and the referenced charge was,
图片
https://pubs.acs.org/doi/suppl/10.1021/ja00074a030/suppl_file/ja00074a030_si_001.pdf
There deviation ranged from 0.1 to 0.5, is that huge? @iwatobipen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iwatobipen iwatobipen

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kzfm @iwatobipen @kexul